Add get_extended_pubkey_display() to HWI trait#107
Draft
pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
Draft
Add get_extended_pubkey_display() to HWI trait#107pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
get_extended_pubkey_display() to HWI trait#107pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
Conversation
Contributor
Author
|
tested on wizardsardine/liana@4c08ab5 w/ Ledger Nano S & BitBox02 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a method to
HWItrait for fetch an Xpub w/ a "non-standard" derivation path, this is needed for Ledger & BitBox devices in order to fetch an Xpub w/ m/48'/0'/1'/2' for instance.When this method is called the user will be prompt to ACK before generating the Xpub whereas calling
get_extended_pubkey()will blindly generate the Xpub or fail if "non-standard"